svn-1082: Art(not)work?

[pnose]

Hi everyone,

I finally managed to install svn-1082 on my Solaris10/sparc box and it seems to work even w/ the small changes I made in src/xml-rpc.c in order get it compiled. Coming from 0.2.4 it’s really cool to see and use all the new features. Thanks for all the work, Ron! 🙂

But one thing is missing which did work with my 0.2.4 installation: The artwork doesn’t show up in iTunes (6.0.4.3) anymore, even though it’s mentioned in the log, e.g.:

2006-05-24 17:57:08: Executing: select * from songs where id=5075

2006-05-24 17:57:08: Found image file /export/data/mp3/Phil Collins/_..But Seriously/cover.jpg (fd 11)

2006-05-24 17:57:08: Thread 46: Length of file (remaining) is 5570687

2006-05-24 17:57:08: Updating Content-Type from application/x-dmap-tagged to audio/mp3

2006-05-24 17:57:08: Added *Content-Length=5570687*

2006-05-24 17:57:08: Added *Connection=Close*

2006-05-24 17:57:08: Emitting reponse header Connection: Close

2006-05-24 17:57:08: Emitting reponse header Content-Length: 5570687

2006-05-24 17:57:08: Emitting reponse header Expires: -1

2006-05-24 17:57:08: Emitting reponse header Cache-Control: no-cache

2006-05-24 17:57:08: Emitting reponse header Content-Type: audio/mp3

2006-05-24 17:57:08: Emitting reponse header DAAP-Server: mt-daapd/svn-1082

2006-05-24 17:57:08: Emitting reponse header Accept-Ranges: bytes

2006-05-24 17:57:08: Emitting reponse header Date: Wed, 24 May 2006 15:57:08 GMT2006-05-24 17:57:08: Entering config_set_status

2006-05-24 17:57:08: Exiting config_set_status

2006-05-24 17:57:08: Session 0: Streaming file '08 Heat On The Street.mp3' to 10.1.10.44 (offset 0)

Is this a general problem with svn or 1082 or did I break something in xml-rpc.c? If the latter, how can the source be compiled w/o d_type on the pde-structure? :-/

Thanks a lot,
Pnose

[rpedde]

@pnose wrote:

I finally managed to install svn-1082 on my Solaris10/sparc box and it seems to work even w/ the small changes I made in src/xml-rpc.c in order get it compiled. Coming from 0.2.4 it’s really cool to see and use all the new features. Thanks for all the work, Ron! 🙂

I actually *have* a solaris machine, but I haven’t built on it in a few weeks, so I’m working toward clean builds out of the box on solaris 10.

But one thing is missing which did work with my 0.2.4 installation: The artwork doesn’t show up in iTunes (6.0.4.3) anymore, even though it’s mentioned in the log, e.g.:

Yeah, the art stuff is specific to the tag version. I’m debating what to do with that code. It’s a neat feature, but it’s broken, and it really is intrusive and ugly code-wise.

I’m actually debating axing it, but I get flamed every time I say something like that. :-/

I’m going to have to wrestle to see if i can come up with a decent way to implement that.

Is this a general problem with svn or 1082 or did I break something in xml-rpc.c? If the latter, how can the source be compiled w/o d_type on the pde-structure? :-/
[/quote]

Should be unrealted to d_type.

But no d_type in dirent?!?! Back to stat, I guess.

— Ron[code]
Is this a general problem with svn or 1082 or did I break something in xml-rpc.c? If the latter, how can the source be compiled w/o d_type on the pde-structure? :-/
[/quote]

Should be unrealted to d_type.

But no d_type in dirent?!?! Back to stat, I guess.

— Ron

[pnose]

Hi Ron,

@rpedde wrote:

I actually *have* a solaris machine, but I haven’t built on it in a few weeks, so I’m working toward clean builds out of the box on solaris 10.

that’s great news. Really looking forward to a clean non-linux build as I figured that a Netra X1 is a much prettier home-server than a NSLU2 🙂

@rpedde wrote:

Yeah, the art stuff is specific to the tag version. I’m debating what to do with that code. It’s a neat feature, but it’s broken, and it really is intrusive and ugly code-wise.

I’m actually debating axing it, but I get flamed every time I say something like that.

I wouldn’t go so far and flame you, but not having the possibility to see the covers anymore would be a big loss, especially for the missis 😕

@rpedde wrote:

But no d_type in dirent?!?! Back to stat, I guess.

At least that’s what the compiler suggested…

cu,
pnose

[Author]

Posts