svn-1696 incompatible with foobar/aimp2/vlc

[mas]

Testing out the daap playlist converted in the addon forum I manage to have the prog generate a long playlist which basically looks like this:

#EXTM3U

#EXTINF:231,A*Teens - Take a Chance on Me

http://dummy:[email protected]:80/databases/1/items/1.mp3

#EXTINF:235,A*Teens - One of Us

http://dummy:[email protected]:80/databases/1/items/2.mp3

...lots more...

Now I opened this playlist with

1) VLC:
immediately kills the mt-daapd:

2007-12-11 00:19:37 (40cfe4e0): Could not find requested item 1

2007-12-11 00:19:37 (40cfe4e0): Thread 87: Entering ws_returnerror (404: File Not Found)

2007-12-11 00:19:37 (40cfe4e0): Could not find requested item 1

2007-12-11 00:19:37 (40cfe4e0): Thread 88: Entering ws_returnerror (404: File Not Found)

2007-12-11 00:19:37 (40cfe4e0): Thread 89: Out of memory

2007-12-11 00:19:37: Aborting

2) AIMP2:
Doesnt dump OOM but plays back wrong songs and sometimes none:

2007-12-11 00:22:17 (40cfe4e0): Session 0: Streaming file ’08 – …in that quiet earth.mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:20 (41d4e4e0): Session 0: Streaming file ’07 – Unquiet slumbers for the sleepers.mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:22 (40cfe4e0): Write error: Connection reset by peer
2007-12-11 00:22:23 (40cfe4e0): Could not find requested item 3779
2007-12-11 00:22:23 (40cfe4e0): Thread 26: Entering ws_returnerror (404: File Not Found)
2007-12-11 00:22:24 (40cfe4e0): Could not find requested item 3779
2007-12-11 00:22:24 (40cfe4e0): Thread 27: Entering ws_returnerror (404: File Not Found)
2007-12-11 00:22:27 (41d4e4e0): Session 0: Streaming file ’02 – 1 for the vine.mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:31 (40cfe4e0): Session 0: Streaming file ’04 – Wot gorilla_.mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:33 (41d4e4e0): Write error: Connection reset by peer
2007-12-11 00:22:37 (41d4e4e0): Session 0: Streaming file ’03 – Your own special way.mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:43 (40cfe4e0): Session 0: Streaming file ’07. Tell Me Why – [We Can’t Dance].mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:45 (41d4e4e0): Write error: Connection reset by peer
2007-12-11 00:22:46 (41d4e4e0): Session 0: Streaming file ’07. Tell Me Why – [We Can’t Dance].mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:49 (40cfe4e0): Write error: Connection reset by peer
2007-12-11 00:22:49 (40cfe4e0): Session 0: Streaming file ’02. Jesus He Knows Me – [We Can’t Dance].mp3′ to 192.168.2.1 (offset 0)
2007-12-11 00:22:51 (41d4e4e0): Write error: Connection reset by peer
2007-12-11 00:22:55 (40cfe4e0): Write error: Connection reset by peer

Strange, whats wrong? Why does it refuse to playback some and plays the wrong songs on others?

3) foobar:
No OOM this time but most songs cant be found and again the logs indicate some thing really aint well for what it can playback:

2007-12-11 00:27:51 (40cfe4e0): Write error: Broken pipe

2007-12-11 00:27:51 (40cfe4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 5946481)

2007-12-11 00:27:52 (40cfe4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 0)

2007-12-11 00:27:52 (40cfe4e0): Write error: Broken pipe

2007-12-11 00:27:52 (41d4e4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 5962833)

2007-12-11 00:27:52 (41d4e4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 87)

2007-12-11 00:27:52 (41d4e4e0): Write error: Broken pipe

2007-12-11 00:27:52 (40cfe4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 0)

2007-12-11 00:27:52 (40cfe4e0): Write error: Broken pipe

2007-12-11 00:27:52 (41d4e4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 5962833)

2007-12-11 00:27:52 (41d4e4e0): Session 0: Streaming file '14. Still Got the Blues - [Out in the Fields The Very Best Of].mp3' to 192.168.2.1 (offset 87)

Now I have no idea if the problem is with mt-daapd and/or with the programs used for streaming and/or with the autogenerated playlist but likely a bit of all…

[mas]

P.S.:

The OOM with VLC is reproducible to 100% here. Dunno what VLC does but it shouldnt be able to shoot down firefly so easily when a Roku, the flashapplet and the other clients dont manage to.

So I guess there is at least also a bug in firefly.

[rpedde]

@mas wrote:

P.S.:

The OOM with VLC is reproducible to 100% here. Dunno what VLC does but it shouldnt be able to shoot down firefly so easily when a Roku, the flashapplet and the other clients dont manage to.

So I guess there is at least also a bug in firefly.

There is no shortage of bugs there. The http auth stuff still looks not quite right, and the request header parsing is probably pretty naive. I think the query parser is okay, and I think the uri parsing is alright as well.

But there are still areas I know aren’t right. Those I know I intend to clean up before a stable, and I hope to fuzz out what I miss from a vgrep.

But yeah… there are plenty of lurking evils there.

[EVILRipper]

I have tried the same as you. I have generated a .m3u and opened the playlist in VLC.
To my surprise, it appeared to work like a charm.
No idea what could cause your VLC to kill your firefly server…

… Just before clicking submit, VLC crashed on me, while trying to play another song. I guess VLC just isn’t really good at playing streams. 🙂

[mas]

The crash is an OOM so likely VLC does something that causes firefly to consume lots of memory.

These slugs dont have so much free memory especially when you also run other stuff on them.

[blamm]

Just found this on the Foobar FAQ

Playing certain files over HTTP doesn’t seem to work in foobar2000. It works in other players. What’s wrong?

foobar2000 uses MIME types to determine the file type of a given file. If an invalid MIME type is returned, it will cause foobar2000 to use the wrong decoder. If an unidentified MIME type is returned, foobar2000 will use the extension to determine the file’s contents. Using the extension to determine the file’s contents is a difficult thing to do in code, and is unlikely to be included in foobar2000. To fix the problem, get the server to return valid MIME types. This is a server-side problem, not a foobar2000 problem.”

Does Firefly return the right mime type?

[rpedde]

@blamm wrote:

Just found this on the Foobar FAQ

Playing certain files over HTTP doesn’t seem to work in foobar2000. It works in other players. What’s wrong?

foobar2000 uses MIME types to determine the file type of a given file. If an invalid MIME type is returned, it will cause foobar2000 to use the wrong decoder. If an unidentified MIME type is returned, foobar2000 will use the extension to determine the file’s contents. Using the extension to determine the file’s contents is a difficult thing to do in code, and is unlikely to be included in foobar2000. To fix the problem, get the server to return valid MIME types. This is a server-side problem, not a foobar2000 problem.”

Does Firefly return the right mime type?

Only if audio/mp3 isn’t the right mime type. Not sure what it’s looking for.

What kind of file are you trying to stream?

[blamm]

Hi.

It a transcoded FLAC, which I assume should be audio/wav?

[rpedde]

@blamm wrote:

Hi.

It a transcoded FLAC, which I assume should be audio/wav?

yup. if you do a -d9, you should see a line that says something like “changing content-type to audio/wav”. That will confirm it.

It’s possible I don’t have the right mimetypes on everything, since I basically just change them to audio/file_extension. audio/flac, audio/ogg, etc. That’s probably not right for .m4a. It’s probably audio/mpeg.

But if it’s transcoded flac, that’s almost certainly right.

— Ron

[Author]

Posts