svn 1586 crashed when scan

[rpedde]

@yllu wrote:

I tried to set PATH_MAX to 2048.
I also tried to modify line 334 in mp3-scanner.c to set
char de[sizeof(struct dirent) + MAXNAMLEN + 1]; to char de[sizeof(struct dirent) + MAXNAMLEN + 1024];.
However, the tests both failed.
And I can not figure out what’s wrong with line 365 in mp3-scanner.c.

Looks to me like it should be:

err=readdir_r(current_dir,(struct dirent *)&de,&pde);

rather than

err=readdir_r(current_dir,(struct dirent *)de,&pde);

— Ron

[yllu]

Unfortunately, the test still failed after modifying line 365 in mp3-scanner.c.

[yllu]

Do you have any new ideas about the bug? 🙄

[rpedde]

@yllu wrote:

Do you have any new ideas about the bug? 🙄

The only thing I can think is stack limits… does this machine has small stack requirements? I’ve got some patches to reduce stack consumption, but I haven’t applied them yet.

[yllu]

Linux arm OS with 2.6.18 kernel.
And no other memory consumption process is running while mt-daapd is running.
It seems like not the stack issue. 😥

[yllu]

I use same files to test on x86 Linux, and also failed.
So I don’t think it’s platform’s issue.

[yllu]

I came up with an idea.
When one process detects the other process with readdir_r failed, it restart the other process again.
Just a workaround.

[Author]

Posts