Feedback on svn-1333

[grommet]

I sent a piece of a debug 9 log to you. Not sure if it’ll help… the full scan just starts slowing down as the makes it to the end of the library. (18 tracks in ~3 seconds toward the end.)

[Gonzo]

Hi,

I’m just trying to compile 1333 on Solaris but xml-rpc.c assumes d_type is present in dirent:

xml-rpc.c: In function `xml_browse_path’:
xml-rpc.c:446: error: structure has no member named `d_type’
xml-rpc.c:446: error: `DT_REG’ undeclared (first use in this function)
xml-rpc.c:446: error: (Each undeclared identifier is reported only once
xml-rpc.c:446: error: for each function it appears in.)
xml-rpc.c:449: error: structure has no member named `d_type’
xml-rpc.c:449: error: `DT_DIR’ undeclared (first use in this function)
xml-rpc.c:450: error: structure has no member named `d_type’
xml-rpc.c:461: error: structure has no member named `d_type’
xml-rpc.c:463: error: structure has no member named `d_type’
xml-rpc.c:463: error: `DT_LNK’ undeclared (first use in this function)

d_type is not present in POSIX, so the code should be prepared via #ifdef to stat() the file in case d_type is not supported.

Ron: Is there a quick workaround or would you be able to make the code independent of d_type’s presence in the target platform?

Best regards,
Gonzo

[rpedde]

@grommet wrote:

I sent a piece of a debug 9 log to you. Not sure if it’ll help… the full scan just starts slowing down as the makes it to the end of the library. (18 tracks in ~3 seconds toward the end.)

Got the fix for this in svn, I think.

— Ron

[rpedde]

@Gonzo wrote:

Ron: Is there a quick workaround or would you be able to make the code independent of d_type’s presence in the target platform?

Nope, I’ll have to do a stat is all.. Perhaps I should have just done that to begin with.

I’ll try and fix that today before the next nightly.

— Ron

[grommet]

Thanks, Ron. Looking forward to the fix. I think I’ll take a break from that Playlist oddness until the next svn with old full scan speeds…

[rpedde]

@Gonzo wrote:

Ron: Is there a quick workaround or would you be able to make the code independent of d_type’s presence in the target platform?

In retrospect, you can just cut the body out of the function — the function isn’t used right now, it’s for path browsing on the web interface, which isn’t implemented yet.

Sorry… should have thought of that.

— Ron

[Author]

Posts